Comment fixes

This commit is contained in:
Johan B.W. de Vries 2022-12-26 13:35:26 +01:00
parent 4876be77fd
commit 8f8f79d799

View File

@ -41,7 +41,7 @@ def phasm_parse(source: str) -> Module:
our_visitor = OurVisitor() our_visitor = OurVisitor()
return our_visitor.visit_Module(res) return our_visitor.visit_Module(res)
OurLocals = Dict[str, Union[FunctionParam]] # Also local variable and module constants? OurLocals = Dict[str, Union[FunctionParam]] # FIXME: Does it become easier if we add ModuleConstantDef to this dict?
class OurVisitor: class OurVisitor:
""" """
@ -147,7 +147,7 @@ class OurVisitor:
if node.returns is not None: # Note: `-> None` would be a ast.Constant if node.returns is not None: # Note: `-> None` would be a ast.Constant
function.returns_type3 = self.visit_type(module, node.returns) function.returns_type3 = self.visit_type(module, node.returns)
else: else:
# Mostly works already, needs to fix Function.returns_type3 and have it updated # FIXME: Mostly works already, needs to fix Function.returns_type3 and have it updated
raise NotImplementedError('Function without an explicit return type') raise NotImplementedError('Function without an explicit return type')
_not_implemented(not node.type_comment, 'FunctionDef.type_comment') _not_implemented(not node.type_comment, 'FunctionDef.type_comment')